Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaHaptics] Add multithread test on LCPForceFeedback component #1581

Merged
merged 4 commits into from
Nov 13, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 31, 2020

test concurrent access to LCPForceFeedback computeforce from another thread

This PR depends on #1576


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Oct 31, 2020
@epernod epernod self-assigned this Oct 31, 2020
@epernod
Copy link
Contributor Author

epernod commented Nov 1, 2020

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

10 days old, this looks fine to me but I am not an intensive user as @courtecuisse or @ChristianDuriez
I would suggest to merge if no further comment

@hugtalbot
Copy link
Contributor

However it seems to add a failing test on the CI: could this be due to the differences noticed between your machine and the CI?
@epernod @guparan

@epernod epernod force-pushed the inf_LCP_testMulti branch 2 times, most recently from 2979404 to 4b70d97 Compare November 11, 2020 03:35
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 12, 2020
@guparan guparan merged commit 3fe47ff into sofa-framework:master Nov 13, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@epernod epernod deleted the inf_LCP_testMulti branch February 1, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants