Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compliant] Add WinchMultiMapping and ContactMultiMapping #1557

Merged
merged 8 commits into from
Nov 4, 2020
Merged

[Compliant] Add WinchMultiMapping and ContactMultiMapping #1557

merged 8 commits into from
Nov 4, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 22, 2020

This is a subset of PR #1492 which aims at merging changes from old branch collodi.
This one only concerns some change done in Compliant plugin

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Oct 22, 2020
@epernod epernod self-assigned this Oct 22, 2020
@epernod
Copy link
Contributor Author

epernod commented Oct 22, 2020

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 4, 2020
@guparan guparan merged commit c5e204a into sofa-framework:master Nov 4, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@epernod epernod deleted the inf_collodi_compliant branch November 20, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees

@epernod epernod

Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @guparan @RomainTestylier