[SofaBaseLinearSolver] Remove virtual function BaseLinearSolver::isMultiGroup #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oup() from LinearSolver and remove never executed code in DefaultCollisionGroupManager
fspadoni
changed the title
fspadoni
changed the title
|
[ci-build][with-all-tests] |
|
I think this includes the #1030 |
hugtalbot
reviewed
May 23, 2019
| for (simulation::Node::ChildIterator it = solvernode->child.begin(), itend = solvernode->child.end(); it != itend; ++it) | ||
| if (node->getContext()->hasAncestor(it->get())) | ||
| return it->get(); | ||
|
|
||
| // group not found, simply return the solver node |
There was a problem hiding this comment.
the comment could be updated or removed
hugtalbot
reviewed
May 23, 2019
examples/Demos/chainHybrid.scn
Outdated
| @@ -4,6 +4,7 @@ | |||
| <BruteForceDetection name="N2" /> | |||
| <NewProximityIntersection name="Proximity" alarmDistance="0.3" contactDistance="0.2" /> | |||
| <DefaultContactManager name="Response" response="default" /> | |||
| <CollisionGroupManager name="Group" /> | |||
hugtalbot
added
pr: clean
guparan
added
pr: status ready
fspadoni
added
pr: status wip
…on. It was previously returning always the root node. The function is not tested in the case of multiple parent nodes.
…_Remove # Conflicts: # SofaKernel/modules/SofaSimulationGraph/DAGNode.cpp
epernod
added
pr: status to review
guparan
added
pr: status wip
fspadoni
added
pr: status to review
hugtalbot
approved these changes
Jul 15, 2019
hugtalbot
added
pr: status ready
guparan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual function BaseLinearSolver::isMultiGroup() returns always false because multi group solver is no more supported after PR #901 in all LinearSolver classes.
Needs #1060 to be merged first
This PR:
Reviewers will merge only if all these checks are true.