[SofaSimulationGraph] Fix CollisionGroupManager wrong search of deformable object node #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collision group nodes already created. The search was always failing and a new collision group was always created and added in the scene graph.
hugtalbot
added
pr: fix
|
Nice Federico, will you PR the removal of the MultiGroup (maybe another PR)? if not, I can do it |
hugtalbot
reviewed
May 23, 2019
| removedGroup.push_back(group2); | ||
| //delete group2; | ||
| removedGroup.push_back(collGroup2); | ||
| //delete group2; |
examples/Demos/chainHybrid.scn
Outdated
| @@ -16,6 +17,6 @@ | |||
| <include name="FEM" href="Objects/TorusFEM.xml" dx="2.5" /> | |||
| <include name="Spring" href="Objects/TorusSpring.xml" dx="5" rx="90" /> | |||
| <include name="FFD" href="Objects/TorusFFD.xml" dx="7.5" /> | |||
| <include name="TorusRigid" href="Objects/TorusRigid.xml" dx="10" rx="90" /> | |||
| <!-- <include name="TorusRigid" href="Objects/TorusRigid.xml" dx="10" rx="90" /> --> | |||
There was a problem hiding this comment.
You deleted one of the tori on purpose?
There was a problem hiding this comment.
I deleted one for debugging. I will add it back.
|
Yes , for me it's better to create a new PR because the removal of
isMultiGroup() function will affect the LinearSolver and other few files
not only the CollisionGroupManager.
I think I can do it quickly from this branch to avoid conflicts.
I let you know
…On Thu, May 23, 2019 at 2:58 PM Hugo ***@***.***> wrote:
Nice Federico, will you PR the removal of the MultiGroup (maybe another
PR)? if not, I can do it
Cheers
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1060?email_source=notifications&email_token=AA55OZHW3KLSKL43E6LUPW3PW2IGPA5CNFSM4HOWAPAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWCEIMI#issuecomment-495207473>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA55OZDPDLZSGI2CDTSO5C3PW2IGPANCNFSM4HOWAPAA>
.
|
|
[ci-build][with-all-tests] |
|
[ci-build][with-all-tests] |
6 tasks
guparan
added
pr: status wip
|
[ci-build][with-regression-tests] |
…on. It was previously returning always the root node. The function is not tested in the case of multiple parent nodes.
…monParent function.
|
[ci-build][with-regression-tests][with-scene-tests] |
epernod
added
pr: status to review
guparan
added
pr: status wip
…GroupManager::createGroups function. Clean DAGNode::findCommonParent function.
…n model component and linear solver are in the same node.
fspadoni
added
pr: status to review
guparan
added
pr: status ready
guparan
changed the title
guparan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in DefaultCollisionGroupManager::createGroups the wrong search of deformable object nodes in collision group nodes already created.
The search was always failing and a new collision group was always created and added in the scene graph.
This PR is supposed to explain the wrong behavior issue #994
This PR:
Reviewers will merge only if all these checks are true.