-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaSimulationGraph] Fix CollisionGroupManager wrong search of deformable object node #1060
[SofaSimulationGraph] Fix CollisionGroupManager wrong search of deformable object node #1060
Conversation
… collision group nodes already created. The search was always failing and a new collision group was always created and added in the scene graph.
Nice Federico, will you PR the removal of the MultiGroup (maybe another PR)? if not, I can do it |
removedGroup.push_back(group2); | ||
//delete group2; | ||
removedGroup.push_back(collGroup2); | ||
//delete group2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be removed
examples/Demos/chainHybrid.scn
Outdated
@@ -16,6 +17,6 @@ | |||
<include name="FEM" href="Objects/TorusFEM.xml" dx="2.5" /> | |||
<include name="Spring" href="Objects/TorusSpring.xml" dx="5" rx="90" /> | |||
<include name="FFD" href="Objects/TorusFFD.xml" dx="7.5" /> | |||
<include name="TorusRigid" href="Objects/TorusRigid.xml" dx="10" rx="90" /> | |||
<!-- <include name="TorusRigid" href="Objects/TorusRigid.xml" dx="10" rx="90" /> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You deleted one of the tori on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted one for debugging. I will add it back.
Yes , for me it's better to create a new PR because the removal of
isMultiGroup() function will affect the LinearSolver and other few files
not only the CollisionGroupManager.
I think I can do it quickly from this branch to avoid conflicts.
I let you know
…On Thu, May 23, 2019 at 2:58 PM Hugo ***@***.***> wrote:
Nice Federico, will you PR the removal of the MultiGroup (maybe another
PR)? if not, I can do it
Cheers
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1060?email_source=notifications&email_token=AA55OZHW3KLSKL43E6LUPW3PW2IGPA5CNFSM4HOWAPAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWCEIMI#issuecomment-495207473>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA55OZDPDLZSGI2CDTSO5C3PW2IGPANCNFSM4HOWAPAA>
.
|
[ci-build][with-all-tests] |
[ci-build][with-all-tests] |
[ci-build][with-regression-tests] |
…on. It was previously returning always the root node. The function is not tested in the case of multiple parent nodes.
…monParent function.
[ci-build][with-regression-tests][with-scene-tests] |
…GroupManager::createGroups function. Clean DAGNode::findCommonParent function.
…n model component and linear solver are in the same node.
Fix in DefaultCollisionGroupManager::createGroups the wrong search of deformable object nodes in collision group nodes already created.
The search was always failing and a new collision group was always created and added in the scene graph.
This PR is supposed to explain the wrong behavior issue #994
This PR:
Reviewers will merge only if all these checks are true.