Disable MacOS CI build for now. #364
Conversation
olivier-roussel
force-pushed
the
remove_macos_ci
branch
from
ee00431
to
1f4db3e
Compare
|
Instead of removing mac, I would just tell github actions to not skip the publishing of the release when there is an error. in the deploy job, you need to set the I did it on the https://github.com/sofa-framework/Regression/ repo and it works |
.github/workflows/ci.yml
Outdated
| @@ -15,6 +15,7 @@ jobs: | |||
| build-and-test: | |||
| name: Run on ${{ matrix.os }} with SOFA ${{ matrix.sofa_branch }} and python ${{ matrix.python_version }} | |||
| runs-on: ${{ matrix.os }} | |||
| continue-on-error: true # as macos is always failing... | |||
There was a problem hiding this comment.
This line should be in the deploy job, not the build-and-test job 🤐
There was a problem hiding this comment.
Indeed... but the continue-on-error: true is already there.
So if I understand correctly, the Deploy artifacts was actually Ok, just not uploading the macOS release, other are properly uploaded, and we can close this PR.
There was a problem hiding this comment.
So why SofaDefrost/Cosserat#82 is failing?
There was a problem hiding this comment.
Don't know yet. SofaDefrost/Cosserat#82 fails because it fails to get the master-nightly release of SofaPython3 on Linux and Windows. I thought it was because there were not available as not uploaded due to the broken CI, but looks like I'm wrong.
I'm on it.
There was a problem hiding this comment.
Isn't it because softprops/action-gh-release@v1 that uploads all zip files fails on macOS file and just stop, as a whole function, so none of zip files are uploaded yet. Even if the Deploy articfacts action continue with the continue-on-error: true ?
I'll dig on this function.
There was a problem hiding this comment.
Ok, looks like the fail_on_unmatched_files: false key for softprops/action-gh-release@v1 is actually what we are looking for.
There was a problem hiding this comment.
stupidly i did it on regression but i forgot it https://github.com/sofa-framework/Regression/blob/e3ac7458885b6229d803469c90cd2d15343389a1/.github/workflows/ci.yml#L117C9-L117C9
|
Looks like this PR deserve a bit of squashing before merge |
That's the default practice when merging in the SOFA environment |
Thanks for the info. That was my guess at it is common, but did not found the info https://www.sofa-framework.org/community/doc/contributing-to-sofa/contributing/ |
olivier-roussel
force-pushed
the
remove_macos_ci
branch
from
4b64fe4
to
91e999c
Compare
|
If everything is OK to you, could you merge so that it will unlock the WIP on related PRs ? |
No description provided.