Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v23.06 ci #81

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

olivier-roussel
Copy link
Contributor

  • Update ci.yml to run CI on the v23.06 branch (and not master)
  • Temporarily disable MacOS build as it seems down

@olivier-roussel
Copy link
Contributor Author

CI ended up in download timeouts, no idea why.

@alxbilger
Copy link
Member

My guess is that downloading an item on https://download.qt.io/official_releases/online_installers/ does not respond

@olivier-roussel
Copy link
Contributor Author

@alxbilger
Copy link
Member

It's a shame that Qt is required whereas this plugin does not need it

@olivier-roussel
Copy link
Contributor Author

As for other plugins relying on SofaPython3, looks like CI needs the SofaPython v23.06 release. I will fix this when once available.

@olivier-roussel
Copy link
Contributor Author

Looks like even sofa-framework/SofaPython3#364 won't fix the CI here.
Here the CI is trying to get (limited to the Ubuntu case):
Getting SofaPython3 from https://github.com/sofa-framework/SofaPython3/releases/download/release-master-nightly/SofaPython3_master-nightly_python-3.8_for-SOFA-v23.06_Linux.zip
which is not available.
sofa-framework/SofaPython3#364 will make available again only the master release, i.e. :
https://github.com/sofa-framework/SofaPython3/releases/download/release-master-nightly/SofaPython3_master-nightly_python-3.8_for-SOFA-master_Linux.zip.
But this v23.06 release of the plugin should rely on v23.06 release of SofaPython3 instead. I guess I will probably have to dig into the GitHub actions to make this possible.

@olivier-roussel olivier-roussel marked this pull request as draft July 26, 2023 15:44
@olivier-roussel olivier-roussel marked this pull request as ready for review July 26, 2023 16:03
@olivier-roussel olivier-roussel marked this pull request as ready for review July 27, 2023 14:05
@alxbilger alxbilger merged commit 47babe9 into SofaDefrost:v23.06 Jul 28, 2023
3 of 4 checks passed
@olivier-roussel olivier-roussel deleted the fix_v23.06_ci branch August 9, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants