Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache-control header to client source #2907

Conversation

maxlego
Copy link
Contributor

@maxlego maxlego commented Apr 1, 2017

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

No cache-control header is sent when requesting clien script

New behaviour

Server will send cache-control header with value "public, max-age=0"

Other information (e.g. related issues)

@darrachequesne darrachequesne changed the base branch from master to develop November 20, 2018 07:01
@darrachequesne darrachequesne merged commit b00ae50 into socketio:develop Nov 20, 2018
@darrachequesne
Copy link
Member

Finally! Thanks 👏

@darrachequesne darrachequesne added this to the 2.2.0 milestone Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants