Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export ManagerOptions #1398

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Nov 10, 2020

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • other

Current behaviour

ManagerOptions is not exported in type definition.

New behaviour

Exported.

Other information (e.g. related issues)

Additionally I think types for options should be originally partial type.

@keroxp
Copy link
Contributor Author

keroxp commented Nov 11, 2020

@darrachequesne Excuse me, would you check why ci doesn't pass? This is just a small type export change.

@darrachequesne darrachequesne merged commit 96cd2c9 into socketio:master Nov 16, 2020
@darrachequesne
Copy link
Member

Thanks a lot!

The CI fails because the Sauce Labs token is not exposed to builds that were triggered from a fork. So, no worry!

@keroxp
Copy link
Contributor Author

keroxp commented Nov 19, 2020

@darrachequesne Thanks!

@darrachequesne darrachequesne added this to the 3.0.2 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants