Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke/fix broken test #1652

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Smoke/fix broken test #1652

merged 2 commits into from
Feb 22, 2021

Conversation

Avishagp
Copy link
Contributor

@Avishagp Avishagp commented Feb 22, 2021 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes some flaky tests:

@Avishagp Avishagp requested a review from a team as a code owner February 22, 2021 13:49
@Avishagp Avishagp requested a review from a team February 22, 2021 13:49
@Avishagp Avishagp requested a review from a team as a code owner February 22, 2021 13:49
@github-actions
Copy link
Contributor

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against fbe3e64

@aron
Copy link
Contributor

aron commented Feb 22, 2021

Hey @Avishagp, do you have examples of the flakes for IaC tests?

rontalx
rontalx approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@rontalx rontalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Avishagp Avishagp merged commit 5391431 into master Feb 22, 2021
@Avishagp Avishagp deleted the smoke/fix-broken-test branch February 22, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rontalx rontalx rontalx approved these changes

@maxjeffos maxjeffos maxjeffos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Avishagp @aron @rontalx @maxjeffos