Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Bump schema-ddl library to 0.3.1 #157

Closed
alexanderdean opened this issue May 1, 2016 · 3 comments
Closed

Bump schema-ddl library to 0.3.1 #157

alexanderdean opened this issue May 1, 2016 · 3 comments
Assignees
@chuwy
Labels
bug
Milestone
Version 0.6.2

Comments

@alexanderdean
Copy link
Contributor

alexanderdean commented May 1, 2016 •
edited
Loading

Consider these schemas:

https://github.com/snowplow/iglu-central/tree/master/schemas/com.clearbit

Then look at these table definitions, created with 0.6.1:

https://github.com/snowplow/snowplow/pull/2635/files

Notes:

  • "geo.lat" looks good
  • "geo.lng" looks good
  • "angellist.id" should be a INT NULL, not VARCHAR(4096)
@alexanderdean alexanderdean added this to the Version 0.6.2 milestone May 1, 2016
@chuwy chuwy changed the title DDL handles "null" in type incorrectly Fix incorrect type suggestion for integer with null May 3, 2016
@chuwy
Copy link
Contributor

chuwy commented May 3, 2016

Renamed (this bug affects only integers).

chuwy added a commit that referenced this issue May 3, 2016
@chuwy
Fixed incorrect type suggestion for integer with null (closes #157)
4b2de7c
@chuwy chuwy mentioned this issue May 3, 2016
Closed
@chuwy
Copy link
Contributor

chuwy commented May 3, 2016

This is fixed in #158. But it resolves angellist.id and others to INT, not to BIGINT (which I guess is correct for 2147483647).

@alexanderdean
Copy link
Contributor Author

Thanks @chuwy - I have corrected the ticket to say INT not BIGINT

@chuwy chuwy changed the title Fix incorrect type suggestion for integer with null Bump schema-ddl library to 0.3.1 May 14, 2016
chuwy added a commit that referenced this issue May 14, 2016
@chuwy
Bumped schema-dll library to 0.3.1 (closes #157)
7502f7b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chuwy chuwy

Labels
bug
Projects
None yet
Milestone
Version 0.6.2
Development

No branches or pull requests
2 participants
@alexanderdean @chuwy