Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1636789, SNOW-1636790: Add support for Series.dt.days_in_month/daysinmonth #2151

Merged
merged 2 commits into from
Aug 26, 2024
Merged

SNOW-1636789, SNOW-1636790: Add support for Series.dt.days_in_month/daysinmonth #2151

merged 2 commits into from
Aug 26, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Aug 22, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1636789, SNOW-1636790

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Add support for Series.dt.days_in_month/daysinmonth.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner August 22, 2024 21:09
@sfc-gh-helmeleegy sfc-gh-helmeleegy changed the title SNOW-1636789, SNOW-1636790: Add support for Series.dt.days_in_month/d aysinmonth SNOW-1636789, SNOW-1636790: Add support for Series.dt.days_in_month/daysinmonth Aug 22, 2024
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit a72d75f into main Aug 26, 2024
34 of 35 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1636789 branch August 26, 2024 23:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-helmeleegy @sfc-gh-azhan @sfc-gh-nkrishna