[SNOW-1636680] IR update to include mode for save_as_table in DataFrameWriter #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
requested review from
sfc-gh-azwiegincew and
sfc-gh-oplaton
sfc-gh-lspiegelberg
requested review from
sfc-gh-jdu,
sfc-gh-aling and
sfc-gh-yuwang
and removed request for
a team,
sfc-gh-jdu,
sfc-gh-aling and
sfc-gh-yuwang
sfc-gh-azwiegincew
approved these changes
Aug 22, 2024
sfc-gh-oplaton
approved these changes
Aug 22, 2024
sfc-gh-lspiegelberg
merged commit 5659feb
into
ls-SNOW-1491199-merge-phase0-server-side
9 of 30 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
modetoSpWriteTabelentity, update expectation test to check for this explicitly.Reduces current doctest GH action from:
= 70 failed, 330 passed, 1 skipped, 3451 deselected, 44 warnings in 273.59s (0:04:33) =to:
= 58 failed, 342 passed, 1 skipped, 3451 deselected, 44 warnings in 322.36s (0:05:22) =