Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1558919: Add support for DatetimeIndex ceil, floor and round methods #2135

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

sfc-gh-nkumar
Copy link
Contributor

Fixes SNOW-1558919

Added support for DatetimeIndex ceil, floor and round methods. Raise not implemented error if ambiguous or nonexistent parameter is set.

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1558919-round-floor-ceil branch from f8613a9 to e7c9863 Compare August 21, 2024 17:42
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion, LGTM otherwise

tests/integ/modin/index/test_datetime_index_methods.py Outdated Show resolved Hide resolved
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1558919-round-floor-ceil branch from e7c9863 to 389e610 Compare August 23, 2024 16:52
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Naresh!

@sfc-gh-nkumar sfc-gh-nkumar merged commit a43f398 into main Aug 23, 2024
35 checks passed
@sfc-gh-nkumar sfc-gh-nkumar deleted the nkumar-SNOW-1558919-round-floor-ceil branch August 23, 2024 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants