SNOW-1570734: Reduce describe query when there is no schema change #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1570734-reduce-desc-no-schmea-change
branch
from
108c337
to
9da3614
Compare
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
approved these changes
Aug 20, 2024
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| ### Snowpark Python API Updates | |||
|
|
|||
| #### Improvements | |||
|
|
|||
| - Reduced the number of additional [describe queries](https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-example#retrieving-column-metadata) sent to the server to fetch the metadata of a DataFrame. It is still an experimental feature not enabled by default, and can be enabled by setting `session.reduce_describe_query_enabled` to `True`. | |||
There was a problem hiding this comment.
Suggested change
| - Reduced the number of additional [describe queries](https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-example#retrieving-column-metadata) sent to the server to fetch the metadata of a DataFrame. It is still an experimental feature not enabled by default, and can be enabled by setting `session.reduce_describe_query_enabled` to `True`. | |
| - Reduced the number of additional [describe queries](https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-example#retrieving-column-metadata) sent to the server to fetch the metadata of a DataFrame. It is still an experimental improvement not enabled by default, and can be enabled by setting `session.reduce_describe_query_enabled` to `True`. |
| lambda df: df.filter(col("a") > 2).sample(0.5), | ||
| ], | ||
| ) | ||
| def test_schema_no_change(session, action): |
There was a problem hiding this comment.
Is there a way to count the number of describe queries so you can assert they are 0 (or whatever the reduced number is) as part of the test?
| @@ -4,6 +4,10 @@ | |||
|
|
|||
| ### Snowpark Python API Updates | |||
|
|
|||
| #### Improvements | |||
|
|
|||
| - Reduced the number of additional [describe queries](https://docs.snowflake.com/en/developer-guide/python-connector/python-connector-example#retrieving-column-metadata) sent to the server to fetch the metadata of a DataFrame. It is still an experimental feature not enabled by default, and can be enabled by setting `session.reduce_describe_query_enabled` to `True`. | |||
There was a problem hiding this comment.
Do we have any experimental results on the impact of this improvement?
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1570734-reduce-desc-no-schmea-change
branch
from
6f99186
to
465c937
Compare
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1570734
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
For
filter,sort,limitandsampleAPIs, we don't need to fetch schema/metadata from server because they are not changed.