SNOW-1526422, SNOW-1524697: Remove axis labels and callable names from unsupported aggregation messages. #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m unsupported aggregation messages. Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-mvashishtha
added
the
NO-PANDAS-CHANGEDOC-UPDATES
…orted-aggregation-messages
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
| @@ -117,7 +117,7 @@ def test_unsupported_dataframe_binary_methods(func, func_name, caplog) -> None: | |||
| "func, func_name", | |||
| UNSUPPORTED_BINARY_METHODS, | |||
| ) | |||
| @sql_count_checker(query_count=1) | |||
| @sql_count_checker(query_count=0) | |||
There was a problem hiding this comment.
Before this PR, we would execute a query to add the entire other series to the error message. After this PR, we don't include the other series in the error message.
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-mvashishtha
requested review from
sfc-gh-nkrishna and
sfc-gh-joshi
and removed request for
sfc-gh-nkrishna
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
…orted-aggregation-messages
src/snowflake/snowpark/modin/plugin/_internal/aggregation_utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Rehan Durrani <rehan.durrani@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
…orted-aggregation-messages
sfc-gh-rdurrani
approved these changes
Jul 22, 2024
noloerino
approved these changes
Jul 22, 2024
sfc-gh-joshi
approved these changes
Jul 22, 2024
sfc-gh-mvashishtha
deleted the
mvashishtha/SNOW-1524697-SNOW-1526422-unsupported-aggregation-messages
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way, separate out the
NotImplementedErrormessages about unsupported aggregations from the messages about unsupported groupings (e.g. grouping onaxis=1or grouping by a dataframe).Fixes SNOW-1526422, SNOW-1524697