SNOW-1491329 Support window functions in Snowpark IR #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
changed the title
sfc-gh-lspiegelberg
requested review from
sfc-gh-heshah,
sfc-gh-vbudati,
sfc-gh-azwiegincew and
sfc-gh-oplaton
| ast = proto.SpWindowSpecExpr() | ||
| window_ast = with_src_position(ast.sp_window_spec_order_by) | ||
| window_ast.wnd.CopyFrom(self._ast) | ||
| for e in exprs: |
There was a problem hiding this comment.
there's some code duplication here, could use helper function. For now kept as is to not introduce complexity.
tests/ast/data/windows.test
Outdated
|
|
||
| res2 = res1.select(col("NUM").as_("key"), col("STR").as_("value")) | ||
|
|
||
| res3 = res2.select(avg(col("value")).over(Window.partition_by(col("value")).order_by(col("key")).rows_between(0, 2)).as_("window1"), avg(col("value")).over(Window.order_by(col("key").desc()).range_between(-9223372036854775807, 9223372036854775807)).as_("window2")) |
There was a problem hiding this comment.
Note here that the constants Window.CURRENT_ROW are internally labels for integers. I left a comment here https://github.com/snowflakedb/snowflake/pull/194828/files#r1679926588 to discuss strategies.
sfc-gh-lspiegelberg
requested review from
sfc-gh-jdu,
sfc-gh-yuwang and
sfc-gh-jrose
and removed request for
a team,
sfc-gh-jdu,
sfc-gh-yuwang and
sfc-gh-jrose
sfc-gh-azwiegincew
requested changes
Jul 16, 2024
sfc-gh-azwiegincew
approved these changes
Jul 17, 2024
sfc-gh-lspiegelberg
merged commit ebe4503
into
server-side-snowpark
12 of 14 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support window functions/expressions in Snowpark IR.