Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open telemetry test flakiness in non-localtesting env #1913

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

sfc-gh-yuwang
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 15, 2024
@sfc-gh-yuwang sfc-gh-yuwang force-pushed the yuwang-fix-open-telemetry-flakiness branch from d471a31 to 1cd4066 Compare July 16, 2024 19:59
@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review July 16, 2024 20:57
@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner July 16, 2024 20:57
@sfc-gh-yuwang sfc-gh-yuwang merged commit 8e9cf4f into main Jul 17, 2024
84 of 89 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-fix-open-telemetry-flakiness branch July 17, 2024 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants