Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1516310: [Local Testing] Add support for datediff #1912

Merged
merged 10 commits into from
Jul 19, 2024
Merged

SNOW-1516310: [Local Testing] Add support for datediff #1912

merged 10 commits into from
Jul 19, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1516310

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    This PR adds support for datediff in local test as well as adds a test that verifies more edge cases than the tests that were present.

@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jul 12, 2024
@sfc-gh-jrose sfc-gh-jrose requested review from a team and sfc-gh-aling July 12, 2024 23:37
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review July 15, 2024 17:31
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner July 15, 2024 17:31
sfc-gh-aling
sfc-gh-aling reviewed Jul 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/snowflake/snowpark/mock/_functions.py Show resolved Hide resolved
@sfc-gh-aling
Copy link
Contributor

it looks like the live test is failing, can you check?

@sfc-gh-jrose sfc-gh-jrose merged commit cb20ebe into main Jul 19, 2024
34 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1516310_local_testing_implement_datediff branch July 19, 2024 03:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-jrose @sfc-gh-aling @sfc-gh-aalam