-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1516310: [Local Testing] Add support for datediff #1912
Merged
sfc-gh-jrose
merged 10 commits into
main
from
jrose_snow_1516310_local_testing_implement_datediff
Jul 19, 2024
Merged
SNOW-1516310: [Local Testing] Add support for datediff #1912
sfc-gh-jrose
merged 10 commits into
main
from
jrose_snow_1516310_local_testing_implement_datediff
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
approved these changes
Jul 18, 2024
it looks like the live test is failing, can you check? |
sfc-gh-aling
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1516310
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds support for datediff in local test as well as adds a test that verifies more edge cases than the tests that were present.