Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1445737, SNOW-1445842: Add support for DataFrame/Series.backfill/bfill #1903

Merged
merged 4 commits into from
Jul 17, 2024
Merged

SNOW-1445737, SNOW-1445842: Add support for DataFrame/Series.backfill/bfill #1903

merged 4 commits into from
Jul 17, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1445737 , SNOW-1445842

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Add support for DataFrame/Series.backfill/bfill.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner July 11, 2024 04:16
@sfc-gh-helmeleegy sfc-gh-helmeleegy force-pushed the helmeleegy-SNOW-1445842 branch 2 times, most recently from 8f741e8 to 4ec1e60 Compare July 11, 2024 04:24
@sfc-gh-helmeleegy sfc-gh-helmeleegy force-pushed the helmeleegy-SNOW-1445842 branch 3 times, most recently from 2962a0a to c43345e Compare July 12, 2024 02:46
@sfc-gh-helmeleegy
Copy link
Contributor Author

Hi @sfc-gh-rdurrani @sfc-gh-nkumar @sfc-gh-lmukhopadhyay. This should be ready for review now.

sfc-gh-rdurrani
sfc-gh-rdurrani approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a quick q, but lgtm otherwise!

src/snowflake/snowpark/modin/plugin/docstrings/dataframe.py Show resolved Hide resolved
sfc-gh-lmukhopadhyay
sfc-gh-lmukhopadhyay approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 636cada into main Jul 17, 2024
35 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1445842 branch July 17, 2024 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-rdurrani sfc-gh-rdurrani sfc-gh-rdurrani approved these changes

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay approved these changes

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar sfc-gh-nkumar is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-helmeleegy @sfc-gh-rdurrani @sfc-gh-lmukhopadhyay