Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC FIX: Move unreleased changelog entries to the correct section #1884

Merged
merged 13 commits into from
Jul 16, 2024

Conversation

sfc-gh-jkew
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew commented Jul 8, 2024

Move plot changelog to pandas section
Move entries from the 1.19.0 pandas section to the 1.19.1 section which were not added to the release notes https://github.com/snowflakedb/snowpark-python/releases/tag/v1.19.0
Move snowpark-python and local testing entries unpublished with 1.19.0 into the new section as well.

@sfc-gh-jkew sfc-gh-jkew added the documentation Improvements or additions to documentation label Jul 8, 2024
@sfc-gh-jkew sfc-gh-jkew marked this pull request as ready for review July 8, 2024 19:22
@sfc-gh-jkew sfc-gh-jkew changed the title DOX FIX: Move plot changelog to pandas section DOC FIX: Move plot changelog to pandas section Jul 8, 2024
@sfc-gh-jkew sfc-gh-jkew enabled auto-merge (squash) July 8, 2024 19:29
@sfc-gh-jkew sfc-gh-jkew disabled auto-merge July 8, 2024 19:45
….0 section but added after 1.19.0 was forked for release.
@sfc-gh-jkew sfc-gh-jkew changed the title DOC FIX: Move plot changelog to pandas section DOC FIX: Move unreleased changelog entries to the correct section Jul 8, 2024
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to do the same for Snowpark Python + local testing (the unreleased features) -- I think theirs is affected as well?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
…the 1.19.0 but not released as part of the 1.19.0 release to the 1.19.1 section ( as determined from the release notes )
@sfc-gh-yzou
Copy link
Collaborator

@sfc-gh-nkrishna yes, let me work with @sfc-gh-aalam to go over the release log one more time to do the correction for snowpark python

This reverts commit d54fa80.
…ase notes for 1.19.0 were not correct."

This reverts commit 4ac295f.
@sfc-gh-jkew
Copy link
Contributor Author

@sfc-gh-aalam @sfc-gh-yzou This should reflect the diff with the release notes tag as opposed to the changelog in the branch.

@sfc-gh-jkew sfc-gh-jkew enabled auto-merge (squash) July 10, 2024 05:33
Copy link
Collaborator

@sfc-gh-yzou sfc-gh-yzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did one pass compare with the release log here https://github.com/snowflakedb/snowpark-python/releases/tag/v1.19.0, there seems one mismatch for get_group

CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-jkew sfc-gh-jkew enabled auto-merge (squash) July 15, 2024 23:37
@sfc-gh-jkew sfc-gh-jkew merged commit 0dfd149 into main Jul 16, 2024
34 checks passed
@sfc-gh-jkew sfc-gh-jkew deleted the jkew/fix-plot-changelog branch July 16, 2024 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants