SNOW-1491306 Phase 0 AST for DataFrame first, sample, and random_split #1813
Conversation
sfc-gh-vbudati
added
NO-CHANGELOG-UPDATES
sfc-gh-vbudati
requested review from
sfc-gh-lspiegelberg,
sfc-gh-heshah,
sfc-gh-azwiegincew and
sfc-gh-oplaton
sfc-gh-vbudati
requested review from
sfc-gh-sfan,
sfc-gh-aalam and
sfc-gh-jrose
and removed request for
a team,
sfc-gh-sfan,
sfc-gh-aalam and
sfc-gh-jrose
| @@ -0,0 +1,17 @@ | |||
| ## TEST CASE | |||
There was a problem hiding this comment.
this test will not pass right now since the Local History code has not implemented any "random" functionality yet. A NotImplementedError is raised.
There was a problem hiding this comment.
Is this still true? One way or another, we should make sure that all (not disabled) checked in tests pass.
There was a problem hiding this comment.
I have run into this in a number of recent APIs as well. I've been able to get around this by checking session._conn._suppress_not_implemented_error, which is a new connection property I've added. In many places, I just return None if suppression is enabled.
There was a problem hiding this comment.
@sfc-gh-azwiegincew I'm still unable to get this test to pass. Now, the NotImplementedError is not raised but instead a KeyError is raised:
def handle_function_expression(
exp: FunctionExpression,
input_data: Union[TableEmulator, ColumnEmulator],
analyzer: "MockAnalyzer",
expr_to_alias: Dict[str, str],
current_row=None,
):
. . .
try:
> result = _MOCK_FUNCTION_IMPLEMENTATION_MAP[func_name](*to_pass_args)
E KeyError: 'random'
../../src/snowflake/snowpark/mock/_plan.py:454: KeyError
What should I do to get around this? Should I try to catch the error and check if it's a KeyError with this message?
There was a problem hiding this comment.
In random_split(), right after creating the AST, say something along the lines of if self._conn._suppress_not_implemented_error: return None
…t-sample-random-split
| @@ -0,0 +1,17 @@ | |||
| ## TEST CASE | |||
There was a problem hiding this comment.
Is this still true? One way or another, we should make sure that all (not disabled) checked in tests pass.
|
Ping. |
| @@ -0,0 +1,17 @@ | |||
| ## TEST CASE | |||
There was a problem hiding this comment.
In random_split(), right after creating the AST, say something along the lines of if self._conn._suppress_not_implemented_error: return None
sfc-gh-vbudati
deleted the
vbudati/SNOW-1491306-df-first-sample-random-split
branch
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1491306
Please describe how your code solves the related issue.
This PR adds API coverage for DataFrame first, sample, and random_split. I added tests for the same.