-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding appName alias for Session.builder.app_name #1349
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the end of file in session.py
and add an entry in changelog like Exposed SessionBuilder.appName as an alias for SessionBuilder.app_name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update session.rst so that documentation is also updated
@sfc-gh-aalam is this ready to merge? or there is something else missing |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1292271: Add required alias for appName #1348
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This just adds an alias such that appName will be the same as app_name