address failures

Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
snowflakedb · Oct 2, 2024 · df5113e · df5113e
1 parent 4526d86
commit df5113e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py b/src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
@@ -12402,7 +12402,7 @@ def resample(
             frame = fill_missing_resample_bins_for_frame(
                 qc._modin_frame, rule, start_date, end_date
             )
-            if resample_method in ("sum", "count", "size"):
+            if resample_method in ("sum", "count", "size", "nunique"):
                 values_arg: Union[int, dict]
                 if resample_method == "sum":
                     # For sum(), we need to fill NaN values as Timedelta(0)

diff --git a/src/snowflake/snowpark/modin/plugin/extensions/resample_overrides.py b/src/snowflake/snowpark/modin/plugin/extensions/resample_overrides.py
@@ -347,15 +347,13 @@ def count(self) -> Union[pd.DataFrame, pd.Series]:
 
     def nunique(self, *args: Any, **kwargs: Any) -> pd.Series:
         # TODO: SNOW-1063368: Modin upgrade - modin.pandas.resample.Resample
-        is_series = not self._dataframe._is_dataframe
-
         return self._dataframe.__constructor__(
             query_compiler=self._query_compiler.resample(
                 self.resample_kwargs,
                 "nunique",
                 tuple(),
                 dict(),
-                is_series,
+                True,
             )
         )
 
@@ -621,14 +619,12 @@ def quantile(
     ) -> Union[pd.DataFrame, pd.Series]:
         # TODO: SNOW-1063368: Modin upgrade - modin.pandas.resample.Resample
         agg_kwargs = dict(q=q)
-        is_series = not self._dataframe._is_dataframe
-
         return self._dataframe.__constructor__(
             query_compiler=self._query_compiler.resample(
                 self.resample_kwargs,
                 "quantile",
                 tuple(),
                 agg_kwargs,
-                is_series,
+                False,
             )
         )