SNOW-1269024 Installing multiple Java versions for test purposes #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-krosinski
requested review from
sfc-gh-japatel,
sfc-gh-tzhang,
sfc-gh-tjones,
sfc-gh-rcheng and
a team
as code owners
sfc-gh-tzhang
approved these changes
Apr 23, 2024
| @@ -18,9 +18,12 @@ jobs: | |||
| - name: Checkout Code | |||
| uses: actions/checkout@v2 | |||
| - name: "Install Java 8" | |||
There was a problem hiding this comment.
Let's update the name as well
There was a problem hiding this comment.
Decided to go with different approach - here only Java 8 is installed, hence the name remains the same.
Added JAVA distribution as it no longer dafaults to 'zulu' and is required parameter.
Added JAVA distribution as it no longer dafaults to 'zulu' and is required parameter.
Changed approach to only install second JAVA - the one required for tests, matrix for test-JAVA version
Add verification of java used by print to log
Aligned step naming to contain matrix value used
| @@ -14,13 +14,15 @@ jobs: | |||
| matrix: | |||
| apache_kafka_version: [ '2.5.1', '2.8.1', '3.2.1' ] | |||
| snowflake_cloud: [ 'AWS', 'AZURE', 'GCS' ] | |||
| java_test_version: [ '8', '11', '17' ] | |||
| steps: | |||
| - name: Checkout Code | |||
| uses: actions/checkout@v2 | |||
| - name: "Install Java 8" | |||
There was a problem hiding this comment.
why do we need this step? as in we are installing java 8 here but using different versions below.
There was a problem hiding this comment.
the whole point of my change is to use two different versions of java - java 8 for building and unit testing but then 8, 11 and 17 as jre to run the app and verify it against given runtime environment - I added PRs description now as I switched it to "ready for review" so I hope it's more clear.
sfc-gh-gjachimko
approved these changes
Apr 25, 2024
sfc-gh-lshcharbaty
approved these changes
Apr 25, 2024
sfc-gh-krosinski
deleted the
krosinski-SNOW-1269024-add-testing-matrix-to-end-2-end-test-apache-yml
branch
ConfluentSemaphore
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Aug 6, 2024
…wflakedb#824) Building and unit testing process remains the same (Java8) but e2e testing is run on three different versions of JAVA: 8, 11 and 17. This means that there are 3 times more testing jobs, but they all run in parallel, hence total run time should remain ~the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1269024 - adding verification on different versions of JRE
Building and unit testing process remains the same (Java8) but e2e testing is run on three different versions of JAVA: 8, 11 and 17. This means that there are 3 times more testing jobs, but they all run in parallel, hence total run time should remain ~the same.
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- This is test only changenormal
Longer test runs