Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-924672: Upgrade aws-java-sdk, grpc, jackson, netty #1545

Merged
merged 3 commits into from
Oct 31, 2023
Merged

SNOW-924672: Upgrade aws-java-sdk, grpc, jackson, netty #1545

merged 3 commits into from
Oct 31, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

Overview

SNOW-924672
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/671

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #671

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Upgraded the following dependencies:

  • aws-java-sdk 1.12.501 (to match the version in FIPS/pom.xml)
  • jackson 2.15.3
  • jackson-databind 2.15.3
  • netty-buffer/netty-common 4.1.100.Final
  • grpc related dependencies 1.59.0

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title SNOW-924672: Upgrade dependencies versions SNOW-924672: Upgrade aws-java-sdk, grpc, jackson, netty Oct 27, 2023
@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 27, 2023 04:02
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 27, 2023 04:02
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 189d0a8 into master Oct 31, 2023
16 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-924672-upgrade-deps branch October 31, 2023 00:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jl @sfc-gh-igarish