Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword argument for with_pip argument #913

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

s1ck
Copy link
Contributor

@s1ck s1ck commented Mar 18, 2024

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

We were playing around with snow cli mainly to package our own Python libs for uploading them into Snowpark.
Unfortunately, this did not work out of the box so we went down quite some rabbit hole in order to figure
out what's wrong. It turned out that the created virtual env had no pip support which lead to the
problem that the generated python -m pip install -r requirements.txt call always leads to return code 1.
The bug is caused by using a positional parameter instead of the keyword.

Co-Authored-By: Paul Horn <paul.horn@neotechnology.com>
@s1ck s1ck requested a review from a team as a code owner March 18, 2024 18:01
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) March 19, 2024 20:48
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 381ff2a into snowflakedb:main Mar 19, 2024
5 of 8 checks passed
sfc-gh-pczajka pushed a commit that referenced this pull request Mar 27, 2024
Co-authored-by: Paul Horn <paul.horn@neotechnology.com>
sfc-gh-pczajka pushed a commit that referenced this pull request Mar 27, 2024
Co-authored-by: Paul Horn <paul.horn@neotechnology.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants