Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests only when code changes #1560

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Run tests only when code changes #1560

merged 3 commits into from
Sep 11, 2024

Conversation

sfc-gh-turbaszek
Copy link
Collaborator

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Adds paths filter to testing pipelines so we avoid running all testing on PRs changing only text files.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-including-paths

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review September 11, 2024 10:43
@sfc-gh-turbaszek sfc-gh-turbaszek requested a review from a team as a code owner September 11, 2024 10:43
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) September 11, 2024 11:42
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit b586b8e into main Sep 11, 2024
21 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the skip-tests-on-unrelated-changes branch September 11, 2024 12:06
sfc-gh-turbaszek added a commit that referenced this pull request Sep 11, 2024
@sfc-gh-turbaszek
Revert "Run tests only when code changes (#1560)"
d66fc4a 
This reverts commit b586b8e.
sfc-gh-astus pushed a commit that referenced this pull request Sep 11, 2024
@sfc-gh-turbaszek @sfc-gh-astus
Revert "Run tests only when code changes (#1560)"
eeaacfe 
This reverts commit b586b8e.
sfc-gh-astus pushed a commit that referenced this pull request Sep 11, 2024
@sfc-gh-turbaszek
Revert "Run tests only when code changes (#1560)" (#1563)
6595b05 
This reverts commit b586b8e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-turbaszek @sfc-gh-jsikorski