SNOW-1643030 Append username template for v1.0 PDFs #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
force-pushed
the
frank-fix-migrate-username
branch
from
02751a1
to
0318e24
Compare
Comment on lines
-171
to
-177
| # name: test_migrating_native_app_raises_error | ||
| ''' | ||
| +- Error ----------------------------------------------------------------------+ | ||
| | Your project file contains a native app definition. Conversion of Native | | ||
| | apps is not yet supported | | ||
| +------------------------------------------------------------------------------+ | ||
|
|
There was a problem hiding this comment.
just removed this unused snapshot
sfc-gh-fcampbell
force-pushed
the
frank-fix-migrate-username
branch
from
4306f0e
to
b679d47
Compare
sfc-gh-fcampbell
force-pushed
the
frank-fix-migrate-username
branch
from
b679d47
to
d4c734e
Compare
sfc-gh-gbloom
previously approved these changes
Sep 12, 2024
sfc-gh-fcampbell
force-pushed
the
frank-fix-migrate-username
branch
from
d4c734e
to
82d0fee
Compare
sfc-gh-pjafari
previously approved these changes
Sep 12, 2024
sfc-gh-fcampbell
force-pushed
the
frank-fix-migrate-username
branch
from
82d0fee
to
0afb93e
Compare
sfc-gh-fcampbell
dismissed stale reviews from sfc-gh-pjafari and sfc-gh-gbloom
via
1d7b757
| else: | ||
| # Backport the PackageV11 default name template, updated for PDFv2 | ||
| package_identifier = _make_template( | ||
| f"fn.concat_ids('{native_app.name}', '_pkg_', fn.sanitize_id(fn.get_username('unknown_user')) | lower)" |
There was a problem hiding this comment.
Nit: would be helpful to extract this naming logic out. Consider putting it near the original implementation (i.e. in api/project/util)
sfc-gh-cgorrie
approved these changes
Sep 13, 2024
sfc-gh-pjafari
approved these changes
Sep 13, 2024
sfc-gh-turbaszek
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
When migrating v1.0 to v2.0, we need to emulate what the
NativeAppProjectModeldoes when the app or package name are not specified, which is to append theUSERenv var to the generated identifier.