Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1650685 fix snowpark package #1541

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Sep 9, 2024

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixes #1535

Fix snow snowpark package create creating empty .zip archives if package name contained capital letters

@sfc-gh-pczajka sfc-gh-pczajka requested a review from a team as a code owner September 9, 2024 12:06
RELEASE-NOTES.md Outdated
* Added support for project definition file defaults in templates.
* Added support for `native_app.package.post_deploy` scripts in project definition file.
* These scripts will execute whenever a Native App Package is created or updated.
* Currently only supports SQL scripts: `post_deploy: [{sql_script: script.sql}]`.
* These scripts will execute whenever a Native App Package is created or updated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoformatter doing stuff again :/

@sfc-gh-turbaszek sfc-gh-turbaszek merged commit ea3a8bf into main Sep 9, 2024
18 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the SNOW-1650685-fix-snowpark-package branch September 9, 2024 15:27
sfc-gh-pczajka added a commit that referenced this pull request Sep 10, 2024
* Fix git execute with upper letter in directory (#1494)

* Stage execute fix (#1525)

Added more tests for stage execute

* Use IDENTIFIER for string literals (#1409)

* Fix git setup with FQN repo names (#1530)

* Snow 1644844 git setup api integration naming fix (#1532)

* git setup: proposed object name should be unique

* add unit tests

* self review

* fix tests

* existing secret can be FQN

* update release notes

* Fetch existing integration in single query

* fix unit tests

* fix release notes

* fix diag_log_path default value (#1533)

* fix diag_log_path default value

* fix tests

* Add unit test checking whether default value got overridden

* Snow 1650685 fix snowpark package (#1541)

* bump version and release notes

* update snapshots

---------

Co-authored-by: Jorge Vasquez Rojas <jorge.vasquezrojas@snowflake.com>
Co-authored-by: Adam Stus <adam.stus@snowflake.com>
Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1650685: snow snowpark package create generates empty .zip archive
2 participants