Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaults and fix mixins behavior #1513

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Remove defaults and fix mixins behavior #1513

merged 11 commits into from
Sep 11, 2024

Conversation

sfc-gh-turbaszek
Copy link
Collaborator

@sfc-gh-turbaszek sfc-gh-turbaszek commented Aug 29, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Removing defaults in favor of mixins. This change adds also support for dictionary and list objects overrides in mixins

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review September 2, 2024 09:03
@sfc-gh-turbaszek sfc-gh-turbaszek changed the title Remove defaults Remove defaults and fix mixins behavior Sep 9, 2024
sfc-gh-astus
sfc-gh-astus previously approved these changes Sep 10, 2024
View reviewed changes
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) September 10, 2024 10:54
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit be1929b into main Sep 11, 2024
21 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the remove-defaults branch September 11, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-cgorrie sfc-gh-cgorrie sfc-gh-cgorrie left review comments

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-turbaszek @sfc-gh-cgorrie @sfc-gh-astus @sfc-gh-jsikorski