Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snow ws migrate fixes #1 #1505

Merged
merged 3 commits into from
Aug 29, 2024
Merged

snow ws migrate fixes #1 #1505

merged 3 commits into from
Aug 29, 2024

Conversation

sfc-gh-jsikorski
Copy link
Collaborator

@sfc-gh-jsikorski sfc-gh-jsikorski commented Aug 28, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

During bug bash we discovered that templated fields still get picked as keys in V2 -this pr aims to fix this

@sfc-gh-jsikorski sfc-gh-jsikorski marked this pull request as ready for review August 29, 2024 08:48
@sfc-gh-jsikorski sfc-gh-jsikorski requested review from a team as code owners August 29, 2024 08:48
@sfc-gh-jsikorski sfc-gh-jsikorski changed the title Mixin fixin' snow ws migrate fixes #1 Aug 29, 2024
@sfc-gh-jsikorski sfc-gh-jsikorski enabled auto-merge (squash) August 29, 2024 10:09
@sfc-gh-jsikorski sfc-gh-jsikorski merged commit 97e473b into main Aug 29, 2024
18 checks passed
@sfc-gh-jsikorski sfc-gh-jsikorski deleted the jsikorski/mixin_fixes branch August 29, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jsikorski @sfc-gh-astus