Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated init commands #1390

Merged
merged 7 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ repos:
^\.github/|
tests/test_data/projects/.*|
tests_integration/test_data/projects/.*|
src/snowflake/cli/templates/.*
files: \.py$|\.pyi$
args:
- --comment-style
Expand Down
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
## Backward incompatibility
* Dropped support for Python below 3.10 version.
* `snow object stage` commands are removed in favour of `snow stage`.
* `snow snowpark init` and `snow streamlit init` commands are removed in favor of `snow init` command.

## Deprecations

Expand Down
65 changes: 0 additions & 65 deletions src/snowflake/cli/api/commands/project_initialisation.py

This file was deleted.

2 changes: 0 additions & 2 deletions src/snowflake/cli/plugins/snowpark/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
identifier_argument,
like_option,
)
from snowflake.cli.api.commands.project_initialisation import add_init_command
from snowflake.cli.api.commands.snow_typer import SnowTyperFactory
from snowflake.cli.api.constants import (
DEFAULT_SIZE_LIMIT_MB,
Expand Down Expand Up @@ -112,7 +111,6 @@
LikeOption = like_option(
help_example='`list function --like "my%"` lists all functions that begin with “my”',
)
add_init_command(app, project_type="Snowpark", template="default_snowpark")


@app.command("deploy", requires_connection=True)
Expand Down
7 changes: 0 additions & 7 deletions src/snowflake/cli/plugins/streamlit/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
with_project_definition,
)
from snowflake.cli.api.commands.flags import ReplaceOption, like_option
from snowflake.cli.api.commands.project_initialisation import add_init_command
from snowflake.cli.api.commands.snow_typer import SnowTyperFactory
from snowflake.cli.api.constants import ObjectType
from snowflake.cli.api.identifiers import FQN
Expand Down Expand Up @@ -70,12 +69,6 @@ def convert(self, value, param, ctx):
is_flag=True,
)

add_init_command(
app,
project_type="Streamlit",
template="default_streamlit",
help_message="Name of the Streamlit app project directory you want to create. Defaults to `example_streamlit`.",
)

add_object_command_aliases(
app=app,
Expand Down
4 changes: 0 additions & 4 deletions src/snowflake/cli/templates/default_snowpark/.gitignore

This file was deleted.

Empty file.
2 changes: 0 additions & 2 deletions src/snowflake/cli/templates/default_snowpark/app/common.py

This file was deleted.

15 changes: 0 additions & 15 deletions src/snowflake/cli/templates/default_snowpark/app/functions.py

This file was deleted.

22 changes: 0 additions & 22 deletions src/snowflake/cli/templates/default_snowpark/app/procedures.py

This file was deleted.

This file was deleted.

23 changes: 0 additions & 23 deletions src/snowflake/cli/templates/default_snowpark/snowflake.yml

This file was deleted.

4 changes: 0 additions & 4 deletions src/snowflake/cli/templates/default_streamlit/.gitignore

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions src/snowflake/cli/templates/default_streamlit/snowflake.yml

This file was deleted.

This file was deleted.

Loading
Loading