Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1532860 clean deprecated snowpark flags, clean help messages #1378

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Snow 1532860 clean deprecated snowpark flags, clean help messages #1378

merged 8 commits into from
Jul 30, 2024

Conversation

sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Jul 29, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

NADE-facing changes

  • Remove "[default: None]" for required arguments (and add test checking for that)

Changes description

  • Remove deprecated flags in snow snowpark command group
  • Remove "[default: None]" for required arguments (and add test checking for that)

Additional checks

  • Checked whether all tests checking for deprecated warnings show "no such option" after the change.

@sfc-gh-pczajka sfc-gh-pczajka requested review from a team as code owners July 29, 2024 14:24
@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as draft July 29, 2024 14:24
@sfc-gh-pczajka sfc-gh-pczajka added the 3.X Breaking and major changes label Jul 30, 2024
@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as ready for review July 30, 2024 11:15
@sfc-gh-pczajka sfc-gh-pczajka changed the title Snow 1532860 clean deprecated commands and flags Snow 1532860 clean deprecated commands and flags, clean help messages Jul 30, 2024
@sfc-gh-turbaszek
Copy link
Collaborator

Can we please separate this change in two? One for flags refactor and one for snow init stuff? It will be easier to review.

@sfc-gh-pczajka sfc-gh-pczajka force-pushed the SNOW-1532860-clean-deprecated-commands-and-flags branch from 803cb24 to 9a0a21e Compare July 30, 2024 12:44
@sfc-gh-pczajka sfc-gh-pczajka changed the title Snow 1532860 clean deprecated commands and flags, clean help messages Snow 1532860 clean deprecated snowpark flags, clean help messages Jul 30, 2024
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the SNOW-1532860-clean-deprecated-commands-and-flags branch from 9a0a21e to abe63eb Compare July 30, 2024 12:48
@sfc-gh-pczajka
Copy link
Collaborator Author

@sfc-gh-turbaszek Split between #1390

@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) July 30, 2024 13:43
sfc-gh-fcampbell
sfc-gh-fcampbell approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-fcampbell sfc-gh-fcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nativeapp changes LGTM

@sfc-gh-pczajka sfc-gh-pczajka merged commit 6f1db14 into main Jul 30, 2024
18 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-1532860-clean-deprecated-commands-and-flags branch July 30, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-fcampbell sfc-gh-fcampbell sfc-gh-fcampbell approved these changes

Assignees
No one assigned
Labels
3.X Breaking and major changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pczajka @sfc-gh-turbaszek @sfc-gh-astus @sfc-gh-fcampbell