Support project definition V2 in streamlit deploy command #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
changed the base branch from
main
to
project-definition-v2-support
| @@ -189,6 +189,9 @@ def _convert_env( | |||
| return env | |||
| return ProjectEnvironment(default_env=(env or {}), override_env={}) | |||
|
|
|||
| def get_entities_by_type(self, entity_type: str): | |||
| return {i: e for i, e in self.entities.items() if e.get_type() == entity_type} | |||
|
|
|||
There was a problem hiding this comment.
@sfc-gh-jsikorski you may be interested in this helper.
sfc-gh-astus
approved these changes
Jul 26, 2024
src/snowflake/cli/api/project/schemas/entities/streamlit_entity.py
Outdated
Show resolved
Hide resolved
src/snowflake/cli/api/project/schemas/entities/streamlit_entity.py
Outdated
Show resolved
Hide resolved
sfc-gh-turbaszek
merged commit 8f9b89a
into
project-definition-v2-support
16 checks passed
| title="Stage in which the app’s artifacts will be stored", default="streamlit" | ||
| ) | ||
| # Possibly can be PathMapping | ||
| artifacts: Optional[List[Path]] = Field( |
There was a problem hiding this comment.
We need to pull up the definition of stage and artifact so the fields can be shared between Streamlit and Application Package (and likely function / spro).
| if not self.artifacts: | ||
| return self | ||
|
|
||
| for artefact in self.artifacts: |
| for artefact in self.artifacts: | ||
| if not artefact.exists(): | ||
| raise ValueError( | ||
| f"Specified artefact {artefact} does not exist locally." |
sfc-gh-turbaszek
added a commit
that referenced
this pull request
Jul 31, 2024
8 tasks
sfc-gh-turbaszek
added a commit
that referenced
this pull request
Jul 31, 2024
sfc-gh-jsikorski
added a commit
that referenced
this pull request
Aug 10, 2024
* Support project definition V2 in streamlit deploy command (#1369) * Init * Solution outline * Fixing paths * build fix * build fix * Update src/snowflake/cli/api/project/schemas/entities/snowpark_entity.py Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> * Update src/snowflake/cli/api/project/schemas/entities/snowpark_entity.py Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> * query problem * Fix for zipper * Test fix * Test fix * Update src/snowflake/cli/plugins/snowpark/commands.py Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> * Update src/snowflake/cli/plugins/snowpark/commands.py Co-authored-by: Patryk Czajka <patryk.czajka@snowflake.com> * Fixes * Test fix * Merge fixes * Test fix * Reformat * Merge cleanup * Fixup * Changed to artifacts * Fixup --------- Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> Co-authored-by: Patryk Czajka <patryk.czajka@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added support for project definition schema version 2 in
snow streamlit deploy. This change requires V2 flag to be enabled.