Temporarily fix handing of python file paths on Windows during Snowpark decorator processing #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk annotation processing
sfc-gh-bgoel
approved these changes
Jun 13, 2024
sfc-gh-turbaszek
pushed a commit
that referenced
this pull request
Jun 17, 2024
…rk decorator processing (#1202)
sfc-gh-turbaszek
pushed a commit
that referenced
this pull request
Jun 17, 2024
…rk decorator processing (#1202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
This is a short-term fix for a blocking bug during setup script generation on Windows. Since the paths are not correctly escape, any '' character is treated as an escape sequence, and the generation step fails. This fix will unblock 2.5.0 with minimal risk. We'll work on a better fix for the next patch release, or the next major release, whichever comes first.
Testing
Manually tested this fix on Windows. Verified that MacOS still works.