Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit check adding license header #1184

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Add pre-commit check adding license header #1184

merged 5 commits into from
Jun 11, 2024

Conversation

sfc-gh-turbaszek
Copy link
Collaborator

@sfc-gh-turbaszek sfc-gh-turbaszek commented Jun 11, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Following best practices we should add license header to all files.

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review June 11, 2024 10:53
@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners June 11, 2024 10:53
sfc-gh-bdufour
sfc-gh-bdufour approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for NADE

@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) June 11, 2024 14:08
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 80791cb into main Jun 11, 2024
21 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the add-license-header branch June 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-turbaszek @sfc-gh-jsikorski @sfc-gh-bdufour @sfc-gh-pczajka