Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support project definition V2 in streamlit deploy command (#1369) #1394

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Support project definition V2 in streamlit deploy command (#1369) #1394

merged 3 commits into from
Jul 31, 2024

Conversation

sfc-gh-turbaszek
Copy link
Collaborator

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

@sfc-gh-turbaszek
Copy link
Collaborator Author

sfc-gh-turbaszek commented Jul 31, 2024 •
edited
Loading

This is duplicate of #1369 but against main instead of future branch

@sfc-gh-turbaszek sfc-gh-turbaszek marked this pull request as ready for review July 31, 2024 15:13
@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners July 31, 2024 15:13
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) July 31, 2024 15:46
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) July 31, 2024 15:47
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 6d1c686 into main Jul 31, 2024
18 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the project-definition-v2-support branch July 31, 2024 15:51
@sfc-gh-turbaszek sfc-gh-turbaszek mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-turbaszek @sfc-gh-pczajka