Skip to content

Commit

Permalink
fixup! fixup! fixup! fixup! Remove defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-turbaszek committed Sep 10, 2024
1 parent 86d0648 commit 3a979f5
Showing 1 changed file with 0 additions and 35 deletions.
35 changes: 0 additions & 35 deletions tests/project/test_project_definition_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,41 +302,6 @@ def test_identifiers():
assert entities["D"].entity_id == "D"


# def test_defaults_are_applied():
# definition_input = {
# "definition_version": "2",
# "entities": {
# "pkg": {
# "type": "application package",
# "identifier": "",
# "artifacts": [],
# "manifest": "",
# }
# },
# "defaults": {"stage": "default_stage"},
# }
# project = DefinitionV20(**definition_input)
# assert project.entities["pkg"].stage == "default_stage"


# def test_defaults_do_not_override_values():
# definition_input = {
# "definition_version": "2",
# "entities": {
# "pkg": {
# "type": "application package",
# "identifier": "",
# "artifacts": [],
# "manifest": "",
# "stage": "pkg_stage",
# }
# },
# "defaults": {"stage": "default_stage"},
# }
# project = DefinitionV20(**definition_input)
# assert project.entities["pkg"].stage == "pkg_stage"


# Verify that each entity model type has the correct "type" field
def test_entity_types():
for entity_type, entity_class in v2_entity_model_types_map.items():
Expand Down

0 comments on commit 3a979f5

Please sign in to comment.