Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #1696

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix linting #1696

merged 3 commits into from
Apr 11, 2022

Conversation

humzaiqbal
Copy link
Contributor

@humzaiqbal humzaiqbal commented Apr 11, 2022

Description of proposed changes

There were a number of mypy issues which haven't been addressed until now

Related issue(s)

Fixes # (issue)
Fixes issues found in #1690

Test plan

Tests should catch these

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@humzaiqbal humzaiqbal marked this pull request as ready for review April 11, 2022 16:18
Copy link
Contributor

@rsmith49 rsmith49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @humzaiqbal

@rsmith49 rsmith49 merged commit 5597ea1 into master Apr 11, 2022
@rsmith49 rsmith49 deleted the humzaiqbal/Fix-linting branch April 11, 2022 16:39
akode pushed a commit to akode/snorkel that referenced this pull request Jun 10, 2022
* Fix linting

* Reformat file

* Fix failing UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants