Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pandas to stable version and numpy accordingly #1633

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

bhancock8
Copy link
Member

@bhancock8 bhancock8 commented Mar 3, 2021

Description of proposed changes

With the previous set of dependencies, I observed the following error after pip installing snorkel v0.9.6 (pandas==1.2.3):

ImportError: this version of pandas is incompatible with numpy < 1.16.5
your numpy version is 1.16.2.
Please upgrade numpy to >= 1.16.5 to use this pandas version

This PR (a) updates pandas to the stable version 1.0.0+ to hopefully reduce backward compatibility issues moving forward, and (b) updates the numpy patch number in accordance with the above error message.

Fixes #1632

Test plan

Executed the sample code from PR #1632 without these changes and observed the above error message, and with these updated package versions and observed expected behavior.

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1633 (caa6f7f) into master (1131d9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          68       68           
  Lines        2157     2157           
  Branches      348      348           
=======================================
  Hits         2099     2099           
  Misses         30       30           
  Partials       28       28           

@bhancock8 bhancock8 requested a review from henryre March 8, 2021 17:59
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhancock8 bhancock8 merged commit a80ca3b into master Mar 8, 2021
@bhancock8 bhancock8 deleted the bh/update-numpy-pandas branch March 8, 2021 18:11
akode pushed a commit to akode/snorkel that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas Panel package deprecated in newer versions
2 participants