Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error logs for classifier operations + fix complex tests #1597

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

vincentschen
Copy link
Member

@vincentschen vincentschen commented Jul 16, 2020

Description of proposed changes

  • Show the underlying exception for failed Operations
  • Fix complex tests by casting inputs to float32 (rather than doubles)

Test plan

  • Ran tox, tox -e complex, tox -e spark locally; passed

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@vincentschen vincentschen requested a review from a team July 16, 2020 19:03
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's track to make sure Travis passes on master

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #1597 into master will increase coverage by 0.06%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   97.13%   97.19%   +0.06%     
==========================================
  Files          56       68      +12     
  Lines        2091     2137      +46     
  Branches      342      343       +1     
==========================================
+ Hits         2031     2077      +46     
  Misses         31       31              
  Partials       29       29              
Impacted Files Coverage Δ
...el/classification/training/loggers/checkpointer.py 96.90% <ø> (ø)
snorkel/labeling/lf/core.py 100.00% <ø> (ø)
snorkel/preprocess/core.py 100.00% <ø> (ø)
snorkel/slicing/sf/nlp.py 100.00% <ø> (ø)
snorkel/classification/training/trainer.py 89.83% <50.00%> (ø)
snorkel/labeling/model/label_model.py 95.54% <50.00%> (ø)
snorkel/classification/multitask_classifier.py 96.53% <100.00%> (ø)
snorkel/labeling/lf/nlp.py 100.00% <100.00%> (ø)
snorkel/map/core.py 100.00% <100.00%> (ø)
snorkel/preprocess/nlp.py 86.66% <100.00%> (ø)
... and 15 more

@vincentschen vincentschen merged commit 5ed7140 into master Jul 16, 2020
@vincentschen vincentschen deleted the vsc-fix-complex branch July 16, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants