Faster symmetry breaking #1502
Merged
Faster symmetry breaking #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
+ Coverage 97.6% 97.61% +<.01%
==========================================
Files 55 55
Lines 2049 2056 +7
Branches 335 339 +4
==========================================
+ Hits 2000 2007 +7
Misses 22 22
Partials 27 27
|
bhancock8
reviewed
Oct 30, 2019
| # Set mu according to highest-scoring permutation | ||
| probs_sum = sum([mu[i : i + k] for i in range(0, self.m * k, k)]) @ P | ||
|
|
||
| m = Munkres() |
There was a problem hiding this comment.
No need for such a short var name here. It's used far away from this definition and just the once.
| # Compute submatrix corresponding to the group. | ||
| probs_proj = probs_sum[[[g] for g in group], group] | ||
| # Use the Munkres algorithm to find optimal permutation. | ||
| # We use minus because we want to maximize diagonal sum, not minimize, |
ajratner
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Use the Munkres algorithm instead of brute force search to find the optimal permutation for breaking column symmetry. Our objective for symmetry breaking is to maximize the total probability of LFs being accurate (summed over LFs). We optimize this over combinations of permutations of columns corresponding to labels with the same prior probability. This is equivalent to optimizing the trace of the product of the summed probabilities matrix with the permutation matrix, which can be done in O(n^3) time.
Fixes # (issue)
#1486
Test plan
Modified existing symmetry breaking test.
Checklist
Need help on these? Just ask!
tox -e complexand/ortox -e sparkif appropriate.