Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SlicingClassifier -> SliceAwareClassifier #1453

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

vincentschen
Copy link
Member

@vincentschen vincentschen commented Sep 6, 2019

Description of proposed changes

Renamed class

Test plan

Fixed corresponding tests

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@vincentschen vincentschen requested a review from a team September 6, 2019 01:36
Copy link
Member

@bhancock8 bhancock8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I think this helps to emphasize that you can do monitoring of slices with other classifiers using the tools we provide, but this is a classifier that will actively utilize that information. LGTM once tests pass!

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1453 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   97.55%   97.49%   -0.06%     
==========================================
  Files          55       55              
  Lines        2002     2078      +76     
  Branches      328      356      +28     
==========================================
+ Hits         1953     2026      +73     
- Misses         22       24       +2     
- Partials       27       28       +1
Impacted Files Coverage Δ
snorkel/slicing/sliceaware_classifier.py 100% <100%> (ø)
snorkel/labeling/model/label_model.py 95.42% <0%> (+0.17%) ⬆️

@vincentschen vincentschen merged commit a089eeb into master Sep 6, 2019
@vincentschen vincentschen deleted the sliceaware_classifier_rename branch September 6, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants