Write complete json log after training #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
=========================================
+ Coverage 97.54% 97.8% +0.25%
=========================================
Files 55 55
Lines 1996 2140 +144
Branches 327 369 +42
=========================================
+ Hits 1947 2093 +146
+ Misses 22 19 -3
- Partials 27 28 +1
|
vincentschen
reviewed
Sep 5, 2019
| @@ -131,4 +131,4 @@ def write_json(self, dict_to_write: Mapping[str, Any], filename: str) -> None: | |||
|
|
|||
| def close(self) -> None: | |||
| """Close writer if necessary.""" | |||
| pass | |||
| self.write_log("log.json") | |||
There was a problem hiding this comment.
naming-wise, this (.close) feels like the wrong place to do the actual dump to disk, it feels like some cleanup operation should be happening here instead.
If it's a special case / hard to fix class names, let's make it clear in the comments for now
There was a problem hiding this comment.
Good point. Refactored close() to cleanup() and added some clarifying docstrings.
vincentschen
approved these changes
Sep 5, 2019
|
Much thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As part of closing the
LogManagerat the end of training, write the run log to file.This appears to have been neglected before because when the log_writer is set to
tensorboard(the default), the TensorBoard log is written incrementally over the course of training, whereas the json log is written all at once at the end.Related issue(s)
Fixes #1439
Test plan
New unit test confirms that log is written at the end of training.
Checklist
Need help on these? Just ask!