Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the pwd_secure_min value (plus 5) for generated password #15187

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 29, 2024

A user in MacAdmins mentioned that our password generation on the user create doesn't respect the pwd_secure_min. The default was 16, but if you had a password requirement of higher than that, it would generate a password that was too short.

This now takes the pwd_secure_min value and adds 5 (for good measure) for the length of password that gets generated.

Copy link

what-the-diff bot commented Jul 29, 2024

PR Summary

  • Enhanced Password Length Flexibility
    The password length in the edit.blade.php file is no longer rigidly set to 16. Now, it's dynamically calculated based on the pwd_secure_min setting with an added 5. This increases versatility in defining password policies.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 55f9886 into develop Jul 29, 2024
9 checks passed
@snipe snipe deleted the feature/sc-26458 branch July 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant