Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nb-NO from no-NO for Norwegian #15143

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Switch to nb-NO from no-NO for Norwegian #15143

merged 3 commits into from
Jul 23, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 23, 2024

So it turns out, according to this conversation in Discord, there are two (technically three?) written Norwegian official languages. Because we were using no-NO, no match could be found in the Bootstrap Tables pagination JS localization, so it was defaulting to English even though they do actually have a translation for nb-NO. This should fix that.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jul 23, 2024

PR Summary

  • Updated Application Locale
    The standard language setting for our app, previously set to English (en), has been changed to United States English (en-US). This minor change was applied across different configurations in our project.

  • Locale Adjustment for Norwegian
    In our code, we had been incorrectly referring to Norwegian as no-NO. This has now been corrected to nb-NO, which is the appropriate code for Norwegian Bokmål, the most widely spoken dialect.

  • Database Migration for Norwegian Locale
    To ensure consistency with our code changes, a new migration file was added. This file updates all instances of the old no-NO locale to nb-NO on the Setting and User models in our database.

  • Language Reference Update
    In our 'localizations' file, we've updated the name linked to the no-NO locale, changing it from 'Norwegian' to 'Norwegian Bokmål'. We've also temporarily removed the old reference to 'Norwegian' to avoid confusion. This helps our system correctly identify and categorize language data.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe changed the title Switch to nb-NO from no-NO Switch to nb-NO from no-NO for Norwegian Jul 23, 2024
@snipe snipe merged commit 900c19b into develop Jul 23, 2024
9 checks passed
@snipe snipe deleted the fixes/no-NO-language branch July 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant