-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #15015 - ability for admins to select default avatar #15027
Conversation
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
PR Summary
|
This allows the admin to upload their own default avatar, or leave one out entirely.
I had to mark the tests here as incomplete, unfortunately, since the
UploadedFile::fake()->image('logo.jpg')
doesn't seem to return a "real" fake image, which means our image upload handler skips over it, so the settings table never gets updated with the returned value. I may keep working on this, but perhaps on Monday we can try to see if there's a workaround. (I tried using->createWithContent()
and doing afile_get_contents()
of one of the demo images that's already in the public root, but no luck.) I'm loathe to refactor that image handler, but perhaps that's how we have to go. It all works fine in the GUI, it's just the way the UploadedFile mock works that's a real pain to work around for testing.Screen.Recording.2024-07-04.at.5.03.14.PM.mov
So the way it currently works,
Fixes #15015.