Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests around Asset Model #14885

Merged

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Jun 17, 2024

Description

This PR adds some tests around the UI for asset models.

I split out the tests from the existing AssetModelsTest into dedicated AssetModelIndexTest and AssetModelStoreTest classes while also adding a small permission check for each and adding an assertion the model was created.

Builds on to the work in this commit: 233e4af

Type of change

  • Testing

Copy link

what-the-diff bot commented Jun 17, 2024

PR Summary

  • Introduction of New Testing Files
    Two new testing files AssetModelIndexTest.php and AssetModelStoreTest.php have been added. These files are set to provide more specific and targeted testing routes for our application, increasing the reliability of our app's performance.

  • Removal of Old Test File
    An outdated or less efficient testing file AssetModelsTest.php has been removed from the system. This is in line with our goal to declutter the codebase and maintain a streamlined, effective testing regime.

@snipe snipe merged commit aba6d9b into snipe:develop Jun 18, 2024
8 checks passed
@marcusmoore marcusmoore deleted the tests/asset-model-test-improvements branch June 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants