Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added user location scope #13879

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 14, 2023

Description

This applies a scope to user search on a location.

image

Fixes #13835

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 14, 2023

PR Summary

  • Extension of Logging Functionality
    Now our system's event tracking potential is included in UsersController.php. This new addition of dependency helps us recognize the flow of data and events for better analysis and debugging.

  • Optimized User Location Search
    The process of searching users based on their location has been refined. Now, a pre-conditional check prevents unnecessary search triggering if the location input field is empty.

  • Better User Searching Mechanism
    Inclusion of the new function UserLocation($query, $location, $search) improves how we handle user search. User searching now litigates not only on the text input but also their location information, hence providing more accurate results.

  • Consistency Across Files
    The User.php file now also has the function UserLocation($query, $location, $search) added. Having it in both files maintains the code's consistency and broadens the extent Utilization of location-specific user searches across the system.

@Godmartinz Godmartinz marked this pull request as ready for review November 16, 2023 19:15
@Godmartinz Godmartinz changed the title added user location scope, still needs fine tuning added user location scope Nov 16, 2023
@snipe snipe merged commit e41a16d into snipe:snipeit_v7_laravel10 Nov 19, 2023
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants