Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] UI: layers sorted lexicographically instead of numerically in the Issues list view. #611

Closed
bartoszek opened this issue Nov 25, 2022 · 4 comments
Closed

[Bug] UI: layers sorted lexicographically instead of numerically in the Issues list view. #611

bartoszek opened this issue Nov 25, 2022 · 4 comments
Assignees
@sn4k3
Labels
bug Something isn't working

Comments

@bartoszek
Copy link

bartoszek commented Nov 25, 2022 •
edited by sn4k3
Loading

System

UVtools v3.8.3 X64
Operative system: Microsoft Windows 10.0.19044 X64
Processor: Intel(R) Core(TM) i7-3720QM CPU @ 2.60GHz
Processor cores: 8
Memory RAM: 7.46 / 15.58 GB
Runtime: win10-x64
Framework: .NET 6.0.11
AvaloniaUI: 0.10.18
OpenCV: 4.6.0

Sreens, resolution, working area, usable area:
1: 1920 x 1080 @ 114.58333333333333% (Primary) (On this)
    WA: 1920 x 1046    UA: 1676 x 913

Path:       C:\Program Files\UVtools\
Executable: C:\Program Files\UVtools\UVtools.exe
Loaded file: xenomorph_legs_hollow_upside_down_tilted_27,5ml_12h40m.ctb [Version: 0] [Class: CTBEncryptedFile]

Description of the bug

Layers in the Issue detector view is sorted lexicographically instead of numerically
image

How to reproduce

  1. Got to the Issues view
  2. Run Detect
  3. Click on "Layers" column header to trigger sorting.
@bartoszek bartoszek changed the title [Bug] Issue: layers sorted lexicographically instead of numerically [Bug] UI: layers sorted lexicographically instead of numerically in the Issues list view. Nov 25, 2022
@sn4k3
Copy link
Owner

sn4k3 commented Nov 25, 2022

Layer column is a string (not number) because of issues that have a range of layers.
I have no control over the sort as it comes from UI framework (DataGrid).

However UVtools sorts by default by layer index as number.
You can also change default Sort on Settings, which may solve this problem

@sn4k3 sn4k3 added the bug Something isn't working label Nov 26, 2022
@bartoszek
Copy link
Author

bartoszek commented Nov 26, 2022 •
edited
Loading

Why not change Layer(s) column sorting to programmatic and override the Sort method?

@sn4k3
Copy link
Owner

sn4k3 commented Nov 26, 2022

I will take a look at it

sn4k3 added a commit that referenced this issue Dec 1, 2022
@sn4k3
v3.9.0
8168988 
- **File formats:**
  - (Add) File extension: .gktwo.ctb to `ChituboxFile` to be able to convert files for UniFormation GKtwo under special CTB format
  - (Add) UniFormation GKtwo compatibility under CTB format, if exporting JXS rename to CTB before open
  - (Fix) CTB, CBDDLP, PHOTON, FDG, PHZ: Read and write files larger then 4GB (#608)
- **PCB Exposure:**
  - (Add) Offset X/Y to offset the PCB from it origin
  - (Add) Allow to toggle between "Show preview image cropped by it bounds" and "Show full preview image (The final result)"
  - (Improvement) Use rectangle instead of line for center line primitive (#607)
  - (Fix) Implement rotation to polygon and center line primitives (#607)
  - (Fix) Macros in a single line was not being parsed (#607)
  - (Fix) Invert color per file was not affecting primitives
- **Network printers:**
  - (Add) Socket requests with TCP and UDP
  - (Add) AnyCubic printer preset (However it can't upload a file)
  - (Add) Scripts in request path to allow a first request to fetch data to the final request:
    -  A script starts with **<\?** and ends with **?>**
    -  First parameter is the first request to get response content from
    -  Second parameter is the regex pattern to match content with
    -  Third parameter is the final request that supports a parameter from regex matching group, eg: **{#1}** is match Group[1] value
    -  **Example:** <\? getfiles > {0}\/(\d+\.[\da-zA-Z]+), > printfile,{#1} ?>
  - (Change) Allow to print a filename without send it when upload request path is empty
  - (Fix) Do not show printers with empty requests
- (Change) Default layer compression to Lz4 instead of Png
- (Improvement) Application is now culture aware but set part of `NumberFormat` to the `InvariantCulture.NumberFormat`
- (Improvement) Material cost now show with the current culture currency symbol due previous change
- (Improvement) Better submit of bug reports using sections and forms
- (Improvement) Linux: AppImage now have a help manual with possible arguments and parameters
- (Improvement) macOS: Codesign app on auto-installer and auto-upgrade to bypass arm64 run restriction (#431)
- (Improvement) macOS: Rebuilt arm64 libcvextern.dylib to run with less dependencies (#431)
- (Improvement) macOS: Try to show missing dependencies from openCV (if any) on the error message
- (Fix) UI: layers sorted lexicographically instead of numerically in the issues list view (#611)
- (Fix) PrusaSlicer printer parameters: UniFormation GKtwo
@sn4k3
Copy link
Owner

sn4k3 commented Dec 1, 2022

Fixed

@sn4k3 sn4k3 closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sn4k3 sn4k3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sn4k3 @bartoszek